Sounds Leak?

[akrep_ve_su]

I have got a question; do undestroyed sounds cause leak? There is a Destroy Sound trigger line, should we use it after each sound play (including sounds from "Unit Transmission" triggers)

 

[TriggerHappy]

Yes, sounds do leak. Though I never deal with sounds so something I say may be wrong.

I don't think in GUI you should destroy sounds since 'i think' GUI uses global sounds, so if you destroy them you cannot use them again.

 

[Dvoth]

You have to destroy sound even in GUI, it leak.

 

[reason 3]

So if u use destroy sound you aren't able to use it again?So what are we supposed to do?let it leak?

 

[Silvenon]

I agree with TriggerHappy, I don't think you're supposed to destroy sounds in GUI. It won't leak because GUI uses a global sound which is reused. So that same sound is played over and over again each time you do "Play Sound". Get it?

That Destroy Sound action is a bit weird and I don't think you should use it.

 

[reason 3]

Are you sure about it though?Don't wanna risk leaks...

 

[akrep_ve_su]

And what about sounds form "Unit Transmission" trigger??

 

[takakenji]

it will play again, it destroys the sound after it is confirmed. so if you want to do something like "-play rickroll" and a rickroll noise comes up, it will destroy it after the sound is over and it may be reused

 

[Dvoth]

Using sound in GUI leak, you have to destroy it. And you can use it again after.

 

[Silvenon]

Well, the good thing about the "Destroy sound" action is that the sound is destroyed when it finishes playing. Maybe they do leak, I don't know much about sounds, but from a jasser persperctive it doesn't make any sense. Try searching the forum for threads about sounds.

 

[Vulcano]

-If you destroy sounds in GUI then you can't use them again.
-In jass you create a new sound everytime you want a sound to play so in jass you can destroy the sound.

 

[reason 3]

So this means whenever i create a sound i have to let it like this?Even if it leaks?

 

[idodik]

You have to destroy the sound using

• Sound - Destroy Sound

otherwise it leaks, it states so clearly in the leaks tutorial. And btw Vulcano is wrong because you can use sounds after destroying them and it doesn't matter if it's jass or GUI, I know that because I use sounds when one of my units attack, and it works each time it attacks.

 

[TriggerHappy]

Just don't destroy them, they aren't making any leaks in GUI. AFAIK.

 

[Silvenon]

Maybe they're created again once they're destroyed, I don't know, but it doesn't leak if you don't destroy them.

This post is too long because everybody is expressing their opinions, but we aren't really getting somewhere. Ask a moderator or something (or search the forum, I'm sure there's a thread like this one).

 

[Reaper2008]

Just don't destroy them, they aren't making any leaks in GUI. AFAIK.

Destroying them is like clearing a global group, since it is reinitialized when it is to be played again. If you don't the handle will remain there. Look at the "sound" BJ's (JNPG/JASScraft) to get what it does.

 

[TriggerHappy]

Can someone test this script, I don't have sound on my computer so I would imagine the sound natives don't work either.

scope sounds initializer onInit
    
    globals
        private sound gg_snd_Doom = CreateSound( "Sound\\Music\\mp3Music\\Doom.mp3", false, false, false, 10, 10, "" )
    endglobals
    
    private function again takes nothing returns nothing
        if gg_snd_Doom != null then
            call BJDebugMsg("Sound still exists")
        else
            call BJDebugMsg("Sound was destroyed")
        endif
    endfunction
    
    private function onInit takes nothing returns nothing
        call SetSoundChannel( gg_snd_Doom, 0 )
        call SetSoundVolume( gg_snd_Doom, 127 )
        call SetSoundPitch( gg_snd_Doom, 1.0 )
        if gg_snd_Doom != null then
            call PlaySoundBJ( gg_snd_Doom )
            call KillSoundWhenDoneBJ( gg_snd_Doom )
        else
            call BJDebugMsg("The sound was never initiliazed")
        endif
        call TimerStart(CreateTimer(), 5, false, function again)
    endfunction
    
endscope

 

[Vulcano]

"Sound still exists"
but i hear nothing on map int, or can't u hear sounds on map init?

 

[Dvoth]

GUI sound does leak, you have to destroy it, it's a fact. When you destroy a sound, it only destroy the currently playing sound. You can use it again without any problems.